Skip to content

Remove OpenCV-based lighthouse geometry estimator #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ataffanel merged 1 commit into from
Sep 16, 2025
Merged

Remove OpenCV-based lighthouse geometry estimator #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/cfclient/ui/dialogs/lighthouse_bs_geometry_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from PyQt6 import QtWidgets
from PyQt6 import uic
from PyQt6.QtCore import QVariant, Qt, QAbstractTableModel, pyqtSignal
from cflib.localization import LighthouseBsGeoEstimator
from cflib.localization import LighthouseSweepAngleAverageReader
from cflib.crazyflie.mem import LighthouseBsGeometry
from cfclient.ui.wizards.lighthouse_geo_bs_estimation_wizard import LighthouseBasestationGeometryWizard
Expand Down Expand Up @@ -138,13 +137,6 @@ def __init__(self, lighthouse_tab, *args):
self._lighthouse_tab = lighthouse_tab

self._estimate_geometry_button.clicked.connect(self._estimate_geometry_button_clicked)
self._simple_estimator = LighthouseBsGeoEstimator()
self._estimate_geometry_simple_button.clicked.connect(self._estimate_geometry_simple_button_clicked)
try:
if not self._simple_estimator.is_available():
self._estimate_geometry_simple_button.setEnabled(False)
except Exception as e:
print(e)

self._write_to_cf_button.clicked.connect(self._write_to_cf_button_clicked)

Expand Down Expand Up @@ -205,10 +197,6 @@ def _estimate_geometry_button_clicked(self):
self._base_station_geometry_wizard.show()
self.hide()

def _estimate_geometry_simple_button_clicked(self):
self._sweep_angle_reader.start_angle_collection()
self._update_ui()

def _write_to_cf_button_clicked(self):
if len(self._newly_estimated_geometry) > 0:
self._lighthouse_tab.write_and_store_geometry(self._newly_estimated_geometry)
Expand Down
7 changes: 0 additions & 7 deletions src/cfclient/ui/dialogs/lighthouse_bs_geometry_dialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@
</property>
</spacer>
</item>
<item>
<widget class="QPushButton" name="_estimate_geometry_simple_button">
<property name="text">
<string>Estimate Geometry Simple</string>
</property>
</widget>
</item>
</layout>
</item>
<item>
Expand Down