Skip to content

Conversation

@kfc35
Copy link
Contributor

@kfc35 kfc35 commented Dec 15, 2025

Objective

Solution

  • Updated the query as suggested in the issue to also check for InheritedVisibility. Entities that have Visibility::INHERITED and InheritedVisibility::HIDDEN should also be ignored for directional navigation

Testing

  • Did you test these changes? If so, how?
    I did not test this change at all! And I wasn’t sure how best to set up an automated test for this since there is not an existing one for that function, else I would have. However, the logic change is simple at least… So if a test is desired, just let me know and please provide me with a little direction :)

@kfc35 kfc35 changed the title fix: ignores nodes that are hidden via their parents in directional nav Fix: Ignores nodes that are hidden via their parents in directional nav Dec 15, 2025
@alice-i-cecile alice-i-cecile modified the milestones: 0.19, 0.18 Dec 15, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 15, 2025
@alice-i-cecile
Copy link
Member

I think we might be able to get away with only checking inherited visibility, but that's a bit less robust, and that would require testing. Up to you if you want to explore that change.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 15, 2025
Merged via the queue into bevyengine:main with commit 5ac16eb Dec 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DirectionalNavigation: auto_rebuild_ui_navigation_graph includes hidden nodes (Visibility vs InheritedVisibility)

3 participants