Skip to content

chore(ui): fix Incorrect links to applications managed by other argo instances #23266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 15, 2025
Merged

chore(ui): fix Incorrect links to applications managed by other argo instances #23266

merged 13 commits into from
Oct 15, 2025

Conversation

@aali309
Copy link
Contributor

@aali309 aali309 commented Jun 4, 2025 •
edited
Loading

Fixes: #12380
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Jun 4, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.79%. Comparing base (b74cf45) to head (83d11f2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/application/application.go 45.00% 7 Missing and 4 partials ⚠️
util/settings/settings.go 25.00% 0 Missing and 3 partials ⚠️
server/cluster/cluster.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23266      +/-   ##
==========================================
- Coverage   60.82%   60.79%   -0.03%     
==========================================
  Files         351      351              
  Lines       60439    60489      +50     
==========================================
+ Hits        36760    36777      +17     
- Misses      20757    20788      +31     
- Partials     2922     2924       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aali309 aali309 force-pushed the incorrectLinks branch 3 times, most recently from 96bedff to 2089901 Compare July 9, 2025 15:53
@aali309 aali309 force-pushed the incorrectLinks branch 2 times, most recently from 435b830 to 4b02ae3 Compare July 15, 2025 13:44
@aali309 aali309 marked this pull request as ready for review July 15, 2025 13:44
@aali309 aali309 requested a review from a team as a code owner July 15, 2025 13:44
keithchong
keithchong requested changes Jul 15, 2025
View reviewed changes
keithchong
keithchong requested changes Jul 18, 2025
View reviewed changes
ishitasequeira
ishitasequeira reviewed Jul 20, 2025
View reviewed changes
ishitasequeira
ishitasequeira reviewed Jul 20, 2025
View reviewed changes
ishitasequeira
ishitasequeira reviewed Jul 20, 2025
View reviewed changes
@yohanb
Copy link

yohanb commented Jul 30, 2025

noticed the issue #12380 as well, glad to see there's a fix on the way.
@aali309 if you need some help, let me know!

@aali309 aali309 force-pushed the incorrectLinks branch 2 times, most recently from de8567e to 73bf297 Compare August 11, 2025 13:00
@aali309 aali309 self-assigned this Aug 12, 2025
@aali309 aali309 requested a review from anandf August 12, 2025 13:06
@aali309 aali309 force-pushed the incorrectLinks branch 3 times, most recently from 45dcdb5 to 0ccaceb Compare August 18, 2025 22:08
@aali309 aali309 force-pushed the incorrectLinks branch 2 times, most recently from ce1bdbd to 6019125 Compare October 10, 2025 17:10
aali309 added 11 commits October 14, 2025 16:34
@aali309
fix: incorrect links to applications managed by other argo instances
b9ff1e9 
Signed-off-by: Atif Ali <[email protected]>

revert manged by url changes

Signed-off-by: Atif Ali <[email protected]>

Expose installationID and serverURL to deep link and API contexts

Signed-off-by: Atif Ali <[email protected]>

fix test errors and run make codegen

Signed-off-by: Atif Ali <[email protected]>

added test for ListLinks and DeepLinks Object

Signed-off-by: Atif Ali <[email protected]>

resolve linter errors

Signed-off-by: Atif Ali <[email protected]>
@aali309
added e2e tests
0eb5e27 
Signed-off-by: Atif Ali <[email protected]>

fix linter failures

Signed-off-by: Atif Ali <[email protected]>

Fix testifylint error: use assert.Empty instead of assert.Equal for empty string

Signed-off-by: Atif Ali <[email protected]>

fix more linter failures

Signed-off-by: Atif Ali <[email protected]>

fix more linter failures on the cluster_test.go

Signed-off-by: Atif Ali <[email protected]>
@aali309
feat (ui): implement correct app linking
0d7a761 
Signed-off-by: Atif Ali <[email protected]>

fix linter errors && cleanup

Signed-off-by: Atif Ali <[email protected]>

fix returning null for the managed-by-url

Signed-off-by: Atif Ali <[email protected]>

resolve linter error

Signed-off-by: Atif Ali <[email protected]>

cleanup

Signed-off-by: Atif Ali <[email protected]>

fix linter error on utils.tsx

Signed-off-by: Atif Ali <[email protected]>

make external link icon available always &&remove redirect logic in loadAppInfo

Signed-off-by: Atif Ali <[email protected]>

use proper navigation patterns

Signed-off-by: Atif Ali <[email protected]>
@aali309
resolve review comments && cleanup
4d33d1e 
Signed-off-by: Atif Ali <[email protected]>

regenerate protobuf files

Signed-off-by: Atif Ali <[email protected]>
@aali309
resolve ci failures
09f6b3d 
Signed-off-by: Atif Ali <[email protected]>
@aali309
trigger ci rerun
fef78ed 
Signed-off-by: Atif Ali <[email protected]>
@aali309
validate managed-by-url
0462e6d 
Signed-off-by: Atif Ali <[email protected]>
@aali309
fix duplicate import
5a39aea 
Signed-off-by: Atif Ali <[email protected]>
@aali309
fix linter errors
ef6e29a 
Signed-off-by: Atif Ali <[email protected]>
@aali309
apply Keith's review comments
bb510e4 
Signed-off-by: Atif Ali <[email protected]>
@aali309
add stopPropagation to nested app links && update resource list
d7eef8a 
Signed-off-by: Atif Ali <[email protected]>
@aali309
fix linter issue
5fd1898 
Signed-off-by: Atif Ali <[email protected]>
keithchong
keithchong approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aali309
trigger ci rerun
83d11f2 
Signed-off-by: Atif Ali <[email protected]>
@keithchong keithchong merged commit 4a71661 into argoproj:master Oct 15, 2025
28 checks passed
@aali309 aali309 deleted the incorrectLinks branch October 16, 2025 17:19
aali309 added a commit to aali309/argo-cd that referenced this pull request Oct 17, 2025
@aali309
chore(ui): fix Incorrect links to applications managed by other argo …
47c4a26 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
@aali309 aali309 mentioned this pull request Oct 17, 2025
Closed
14 tasks
aali309 added a commit to aali309/argo-cd that referenced this pull request Oct 17, 2025
@aali309
chore(ui): fix Incorrect links to applications managed by other argo …
da5d9e7 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
dzahariev pushed a commit to dzahariev/argo-cd that referenced this pull request Oct 20, 2025
@aali309 @dzahariev
chore(ui): fix Incorrect links to applications managed by other argo …
880ca1c 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Dobromir Zahariev <[email protected]>
devopsjedi pushed a commit to devopsjedi/argo-cd that referenced this pull request Oct 21, 2025
@aali309 @devopsjedi
chore(ui): fix Incorrect links to applications managed by other argo …
8727d9a 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
@aali309 aali309 mentioned this pull request Oct 23, 2025
Open
AvhiMaz pushed a commit to AvhiMaz/argo-cd that referenced this pull request Nov 3, 2025
@aali309 @AvhiMaz
chore(ui): fix Incorrect links to applications managed by other argo …
5060fd3 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
@mkilchhofer mkilchhofer mentioned this pull request Nov 7, 2025
Open
14 tasks
mkilchhofer pushed a commit to mkilchhofer/argo-cd that referenced this pull request Nov 7, 2025
@aali309 @mkilchhofer
chore(ui): fix Incorrect links to applications managed by other argo …
ce707ea 
…instances (argoproj#23266)

Signed-off-by: Atif Ali <[email protected]>
@mkilchhofer mkilchhofer mentioned this pull request Nov 7, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithchong keithchong keithchong approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@anandf anandf Awaiting requested review from anandf

@agaudreault agaudreault Awaiting requested review from agaudreault

@andrii-korotkov-verkada andrii-korotkov-verkada Awaiting requested review from andrii-korotkov-verkada

Assignees

@aali309 aali309

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect links to applications managed by other argo instances

4 participants

@aali309 @yohanb @keithchong @ishitasequeira