Skip to content

Conversation

@aali309
Copy link
Contributor

@aali309 aali309 commented Oct 17, 2025

Cherry-pick of #23266 to release-3.2

This is a backport of the managed-by-url feature to release-3.2, which fixes incorrect links to applications managed by other ArgoCD instances.

Original PR: #23266
Fixes: #12380

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@aali309 aali309 requested a review from a team as a code owner October 17, 2025 21:09
@aali309 aali309 force-pushed the cherry-pick-23266-to-3.2 branch from 47c4a26 to da5d9e7 Compare October 17, 2025 21:21
@aali309 aali309 self-assigned this Oct 17, 2025
@aali309 aali309 closed this Oct 17, 2025
@aali309 aali309 deleted the cherry-pick-23266-to-3.2 branch October 17, 2025 21:31
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.59%. Comparing base (d1251f4) to head (da5d9e7).
⚠️ Report is 1 commits behind head on release-3.2.

Files with missing lines Patch % Lines
server/application/application.go 45.00% 7 Missing and 4 partials ⚠️
util/settings/settings.go 25.00% 0 Missing and 3 partials ⚠️
server/cluster/cluster.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.2   #24998      +/-   ##
===============================================
+ Coverage        60.56%   60.59%   +0.02%     
===============================================
  Files              351      351              
  Lines            60235    60285      +50     
===============================================
+ Hits             36483    36529      +46     
  Misses           20829    20829              
- Partials          2923     2927       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant