Make Curve25519 PublicKeys conform to Hashable#175
Closed
Sajjon wants to merge 5 commits intoapple:mainfrom
Sajjon:curve25519_publickeys_hashable
Closed
Make Curve25519 PublicKeys conform to Hashable#175Sajjon wants to merge 5 commits intoapple:mainfrom Sajjon:curve25519_publickeys_hashable
PublicKeys conform to Hashable#175Sajjon wants to merge 5 commits intoapple:mainfrom
Sajjon:curve25519_publickeys_hashable
Conversation
Sajjon
commented
Apr 18, 2023
| return try self.baseKey.keyBytes.withUnsafeBytes(body) | ||
| } | ||
|
|
||
| public static func ==(lhs: Self, rhs: Self) -> Bool { |
Contributor
Author
There was a problem hiding this comment.
Sajjon
commented
Apr 18, 2023
| return try self.baseKey.keyBytes.withUnsafeBytes(body) | ||
| } | ||
|
|
||
| public static func ==(lhs: Self, rhs: Self) -> Bool { |
Contributor
Author
There was a problem hiding this comment.
Sajjon
commented
Apr 18, 2023
| XCTAssertFalse(privateKey.publicKey.isValidSignature(DispatchData.empty, for: DispatchData.empty)) | ||
| } | ||
|
|
||
| func testCurve25519SigningPublicKeyEquatable() throws { |
Contributor
Author
There was a problem hiding this comment.
Sajjon
commented
Apr 18, 2023
| Curve25519.Signing.PrivateKey().publicKey | ||
| ) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Lukasa
requested changes
Apr 18, 2023
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Delaying for future release of CryptoKit.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Curve25519 PublicKeys conform to
HashableN.B. Merge open PR #173 first (or if #173 is closed, close this one too), since this PR builds on top of that.
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
PublicKey's are fundamental building blocks within EC-oriented code bases. They can act as a natural key in Dictionaries and otherwise important property of larger structs, which us developers often would like to make
Hashable. Today, Curve25519 public keys prevent auto-synthesis ofHashablefor any structs they are members of, thus Curve25519 keys ought to beHashable!This poses no security risk nor any performance downgrade.
This PR is an addition of open PR #173.
Modifications:
Curve25519.KeyAgreement.PublicKeyandCurve25519.Signing.PublicKeyhave been madeHashableand unit tests have been added.Result:
Curve25519.KeyAgreement.PublicKeyandCurve25519.Signing.PublicKeyare nowHashable