Make Curve25519 PublicKeys conform to Equatable#173
Closed
Sajjon wants to merge 4 commits intoapple:mainfrom
Sajjon:curve25519_publickeys_equatable
Closed
Make Curve25519 PublicKeys conform to Equatable#173Sajjon wants to merge 4 commits intoapple:mainfrom Sajjon:curve25519_publickeys_equatable
PublicKeys conform to Equatable#173Sajjon wants to merge 4 commits intoapple:mainfrom
Sajjon:curve25519_publickeys_equatable
Conversation
Lukasa
requested changes
Apr 14, 2023
Contributor
Lukasa
left a comment
There was a problem hiding this comment.
Thanks for this. I'm marking this as Request Changes just as a visual note to myself to return to it.
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Curve25519 PublicKeys conform to
EquatableChecklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
When PublicKey's are used in
struct's that are markedEquatablethose structs cannot be auto-synthetized conform toEquatablesince these PublicKeys before this PR do not conform toEquatable. This is rather annoying. And during the 5 years I've been working in the crypto industry I have added my own conformance to CryptoKit's PublicKeys to beEquatableprobably more than 10 times!There exists no security risk in making PublicKeys conform to
Equatable, the current implementation does not usesafeCompare, it could, but I deem it not necessary.There is really no drawback in adding
Equatableconformance.Modifications:
Curve25519.Signing.PublicKeybeEquatableCurve25519.KeyAgreement.PublicKeybeEquatableResult:
Curve25519.Signing.PublicKeyandCurve25519.KeyAgreement.PublicKeynow conform toEquatable.