Make NIST PublicKeys conform to Hashable#176
Make NIST PublicKeys conform to Hashable#176Sajjon wants to merge 4 commits intoapple:mainfrom Sajjon:nist_publickeys_hashable
PublicKeys conform to Hashable#176Conversation
| return pemDocument.pemString | ||
| } | ||
|
|
||
| public static func ==(lhs: Self, rhs: Self) -> Bool { |
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
| return pemDocument.pemString | ||
| } | ||
|
|
||
| public static func ==(lhs: Self, rhs: Self) -> Bool { |
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
| } | ||
|
|
||
|
|
||
| func testP256SigningPublicKeyEquatable() throws { |
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Blocking for future CryptoKit updates.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks for the input here @Sajjon. I'm going to hide both comments, and report @vivoxfold3's, as the assertion is transparently untrue (this is not your first contribution here, and you and I have spoken several times before. The hide is only to keep this PR on-topic, not because your comment wasn't welcome. |
3 participants
Make ALL
NISTPublicKeys conform toHashableN.B. Merge open PR #174 first (or if #174 is closed, close this one too), since this PR builds on top of that.
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
This is the
NISTanalogue counterpart of #175, so the motivation put in there applies here as well.This PR is an addition of open PR #174.
Modifications:
P256,P384andP521's Signing and KeyAgreementPublicKeybeHashable, by...NISTECPublicKeyto beHashableand addinghash:intofunction inECDH.swift.gybResult:
ALL NIST PublicKey's now conform to
Hashable