Pro 8178 add prepend append main #5068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
haroun
commented
Sep 10, 2025
| <div data-apos-refreshable> | ||
| {% block beforeMain %}{% endblock %} | ||
| {% block mainAnchor %}<a name="main"></a>{% endblock %} | ||
| {% component '@apostrophecms/template:inject' with { where: 'main', end: 'prepend', when: 'hmr' } %} |
Contributor
Author
There was a problem hiding this comment.
Not sure about this line with hmr
Contributor
There was a problem hiding this comment.
when: 'hmr' means "inject only when in HMR mode". It wasn't added probably due to performance reasons (with the idea "add it if/when needed".
boutell
requested changes
Sep 10, 2025
Member
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
It doesn't actually go inside the <main> element, which is supplied by project level layout.
So this is essentially beforeMain and afterMain in node injection form. So I would go with those names.
boutell
approved these changes
Sep 10, 2025
Member
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
Actually my suggestion is not possible because of the way "prependNodes" and "appendNodes" work.
So I'm going to approve this as written because I don't have a better suggestion.
myovchev
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
prepend-mainandappend-mainWhat are the specific steps to test this change?
Please check apostrophecms/starter-kit-astro-apollo-assembly#1
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: