Skip to content

Pro 8178 add prepend append main #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2025
Merged

Pro 8178 add prepend append main #5068

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5abbd5e
add injectNodes calls for prepend main and append main
haroun Sep 10, 2025
064ee1f
add prepend and append main with hmr
haroun Sep 10, 2025
3cea98a
update changelog
haroun Sep 10, 2025
25177a5
fix mixed-decls issue
haroun Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Adds

* Custom operations registered with `addCreateWidgetOperation` can now specify an `ifTypesIntersect` property containing an array of widget type names. If the area in question allows at least one, the operation is offered.
* Add `prependNodes` and `appendNodes` calls for `main`.

### Changes

Expand Down
2 changes: 2 additions & 0 deletions modules/@apostrophecms/template/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,8 @@ module.exports = {
data.appendHead = self.injectNodes(req, 'append-head');
data.prependBody = self.injectNodes(req, 'prepend-body');
data.appendBody = self.injectNodes(req, 'append-body');
data.prependMain = self.injectNodes(req, 'prepend-main');
data.appendMain = self.injectNodes(req, 'append-main');

return data;
},
Expand Down
2 changes: 2 additions & 0 deletions modules/@apostrophecms/template/views/outerLayoutBase.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@
<div data-apos-refreshable>
{% block beforeMain %}{% endblock %}
{% block mainAnchor %}<a name="main"></a>{% endblock %}
{% component '@apostrophecms/template:inject' with { where: 'main', end: 'prepend', when: 'hmr' } %}
Copy link
Contributor Author

@haroun haroun Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this line with hmr

Copy link
Contributor

@myovchev myovchev Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when: 'hmr' means "inject only when in HMR mode". It wasn't added probably due to performance reasons (with the idea "add it if/when needed".

{% component '@apostrophecms/template:inject' with { where: 'main', end: 'prepend' } %}
{% block main %}{% endblock %}
{% component '@apostrophecms/template:inject' with { where: 'main', end: 'append', when: 'hmr' } %}
{% component '@apostrophecms/template:inject' with { where: 'main', end: 'append' } %}
{% block afterMain %}{% endblock %}
</div>
Expand Down