-
Notifications
You must be signed in to change notification settings - Fork 0
Pro 8178 add multisite #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llo-pro into pro-8060/palette-config
Pro 8150 seo assistant
Pro 8060/palette config
PRO-8178 Create a starter-kit-astro-apollo-assembly so that customers like iCIMS can use it as an example for Astro + multisite
iCIMS wants to do Astro and they are multisite. Time to catch up with our friends at Michelin. We haven't set up Astro with multisite before, but we know Michelin is doing it with great success. Tech design
Acceptance Criteria
Remember…
|
backend/sites/views/layout.html
Outdated
| @@ -0,0 +1,71 @@ | |||
| {% extends data.outerLayout %} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /login page DOES come from apostrophe, so a basic layout that supports it is still appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to test this out with an actual apostrophecms hosting setup before approving. I'm not 100% sure that portMapping and aposHost: '*' provide quite enough information in that scenario but they might.
|
I will also have to think about how to explain the ramifications for a client like icims who is self-hosted, but first I'll validate that it can work in our own environment so I have something to explain. |
|
It looks like |
…ate and build scripts
…r-kit-astro-apollo-assembly into feature/deploy-test * 'feature/deploy-test' of github.com:apostrophecms/starter-kit-astro-apollo-assembly: silly oversights use main ignore release-id use the right branch remove modules/ subdir with unused code call things what the root package.json calls them production-start script matching the environment settings in the migrate and build scripts APOS_UPLOADFS_ASSETS=1 consistently used dashboards have assets too! orphan logging well that was simple? maybe? 🙏
* main: little things Response to first comments Emojis Minor README update Minor detail change First stab at README update
* pro-8178-add-multisite: little things Response to first comments Emojis Minor README update Minor detail change First stab at README update
Feature/deploy test
Summary
Enable multisite on astro
This PR requires 3 additional PRs before merging
What are the specific steps to test this change?
Backend
cd backendnpm install github:apostrophecms/multisite-dashboardnpm install github:apostrophecms/apostrophenpm run devsite1andsite2Frontend
cd frontendnpm install github:apostrophecms/apostrophe-astronpm run devdashboard.localhost:4321,site1.localhost:4321andsite2.localhost:4321What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: