SPARK-1628: Add missing hashCode methods in Partitioner subclasses #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
Author
There was a problem hiding this comment.
If using numPartitions = partitions, there is a chance that p1 == p2 && p1.numPartitions != p2.numPartitions is true. For example, if rdd.sample is empty, p1 = new RangePartitioner[...](10, rdd, true), and p2 = new RangePartitioner[...](1, rdd, true).
That's confusing. So I changed partitions to rangeBounds.length + 1.
Member
Author
|
Is there any further suggestion about this one? |
pwendell
pushed a commit
to pwendell/spark
that referenced
this pull request
May 12, 2014
…pache#549. remove actorToWorker in master.scala, which is actually not used actorToWorker is actually not used in the code....just remove it Author: CodingCat <[email protected]> == Merge branch commits == commit 52656c2d4bbf9abcd8bef65d454badb9cb14a32c Author: CodingCat <[email protected]> Date: Thu Feb 6 00:28:26 2014 -0500 remove actorToWorker in master.scala, which is actually not used
Contributor
|
Jenkins, test this please. |
Contributor
|
This looks good to me pending test passes. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
Contributor
|
Thanks. I'm merging this in master. |
asfgit
pushed a commit
that referenced
this pull request
Jun 9, 2014
Adding a paragraph clarifying a weird behavior in RangePartitioner. See also #549. Author: Reynold Xin <[email protected]> Closes #1012 from rxin/partitioner-doc and squashes the following commits: 6f0109e [Reynold Xin] SPARK-1628 follow up: Improve RangePartitioner's documentation.
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
JIRA: https://issues.apache.org/jira/browse/SPARK-1628 Added `hashCode` in HashPartitioner, RangePartitioner, PythonPartitioner and PageRankUtils.CustomPartitioner. Author: zsxwing <[email protected]> Closes apache#549 from zsxwing/SPARK-1628 and squashes the following commits: 2620936 [zsxwing] SPARK-1628: Add missing hashCode methods in Partitioner subclasses
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Adding a paragraph clarifying a weird behavior in RangePartitioner. See also apache#549. Author: Reynold Xin <[email protected]> Closes apache#1012 from rxin/partitioner-doc and squashes the following commits: 6f0109e [Reynold Xin] SPARK-1628 follow up: Improve RangePartitioner's documentation.
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
JIRA: https://issues.apache.org/jira/browse/SPARK-1628 Added `hashCode` in HashPartitioner, RangePartitioner, PythonPartitioner and PageRankUtils.CustomPartitioner. Author: zsxwing <[email protected]> Closes apache#549 from zsxwing/SPARK-1628 and squashes the following commits: 2620936 [zsxwing] SPARK-1628: Add missing hashCode methods in Partitioner subclasses
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Adding a paragraph clarifying a weird behavior in RangePartitioner. See also apache#549. Author: Reynold Xin <[email protected]> Closes apache#1012 from rxin/partitioner-doc and squashes the following commits: 6f0109e [Reynold Xin] SPARK-1628 follow up: Improve RangePartitioner's documentation.
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
should use -a in tee
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
### What changes were proposed in this pull request? In ProjectingInternalRow, accessing colOrdinals causes poor performace. Replace colOrdinals with the IndexedSeq type. ### Why are the changes needed? Replace colOrdinals with the IndexedSeq type. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47890 from wzx140/project-row-fix. Lead-authored-by: wzx <[email protected]> (cherry picked from commit 37f2fa9) Signed-off-by: Kent Yao <[email protected]> Co-authored-by: wzx <[email protected]> Co-authored-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-1628
Added
hashCodein HashPartitioner, RangePartitioner, PythonPartitioner and PageRankUtils.CustomPartitioner.