[SPARK-49408][SQL] Use IndexedSeq in ProjectingInternalRow #47890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzx140
force-pushed
the
project-row-fix
branch
from
296dc8e to
6320ebf
Compare
Contributor
Author
|
@aokolnychyi Could you please review it? Really thanks! |
wangyum
reviewed
Sep 4, 2024
|
|
||
| object ProjectingInternalRow { | ||
| def apply(schema: StructType, colOrdinals: Seq[Int]): ProjectingInternalRow = { | ||
| new ProjectingInternalRow(schema, colOrdinals.toIndexedSeq) |
Contributor
There was a problem hiding this comment.
This seems like a classic "accidentally quadratic" O(n^2) issue so you could achieve pretty arbitrary speedups with a contrived benchmark.
From the flamegraph attached to https://issues.apache.org/jira/browse/SPARK-49408 it seems like this would make a pretty substantial difference for that test query: it looks like ~94% of the time was being spent in list traversal.
yaooqinn
approved these changes
Sep 4, 2024
yaooqinn
reviewed
Sep 4, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ProjectingInternalRow.scala
Outdated
Show resolved
Hide resolved
…ectingInternalRow.scala
yaooqinn
added a commit
that referenced
this pull request
Sep 5, 2024
### What changes were proposed in this pull request? In ProjectingInternalRow, accessing colOrdinals causes poor performace. Replace colOrdinals with the IndexedSeq type. ### Why are the changes needed? Replace colOrdinals with the IndexedSeq type. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #47890 from wzx140/project-row-fix. Lead-authored-by: wzx <[email protected]> Co-authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 37f2fa9) Signed-off-by: Kent Yao <[email protected]>
yaooqinn
added a commit
that referenced
this pull request
Sep 5, 2024
### What changes were proposed in this pull request? In ProjectingInternalRow, accessing colOrdinals causes poor performace. Replace colOrdinals with the IndexedSeq type. ### Why are the changes needed? Replace colOrdinals with the IndexedSeq type. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #47890 from wzx140/project-row-fix. Lead-authored-by: wzx <[email protected]> Co-authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 37f2fa9) Signed-off-by: Kent Yao <[email protected]>
Member
|
Merged to master/3.5/3.4. Thank you all. |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
### What changes were proposed in this pull request? In ProjectingInternalRow, accessing colOrdinals causes poor performace. Replace colOrdinals with the IndexedSeq type. ### Why are the changes needed? Replace colOrdinals with the IndexedSeq type. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need to add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47890 from wzx140/project-row-fix. Lead-authored-by: wzx <[email protected]> (cherry picked from commit 37f2fa9) Signed-off-by: Kent Yao <[email protected]> Co-authored-by: wzx <[email protected]> Co-authored-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In ProjectingInternalRow, accessing colOrdinals causes poor performace. Replace colOrdinals with the IndexedSeq type.
Why are the changes needed?
Replace colOrdinals with the IndexedSeq type.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need to add UT
Was this patch authored or co-authored using generative AI tooling?
No