Skip to content

Conversation

@CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Feb 13, 2023

What is the purpose of the change

  1. Add dubbo-maven-plugin module
  2. Migrate the ability of dubbo-native-plugin to dubbo-maven-plugin
  3. Implement automatic generation of dynamic Adaptive classes

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

# Conflicts:
#	dubbo-demo/dubbo-demo-native/dubbo-demo-native-consumer/pom.xml
#	dubbo-demo/dubbo-demo-native/dubbo-demo-native-provider/pom.xml
Signed-off-by: crazyhzm <[email protected]>
@CrazyHZM CrazyHZM added this to the 3.2.0 milestone Feb 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

0.0% 0.0% Coverage
4.0% 4.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (82a29fc) to head (4e6e3c1).
Report is 1400 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #11540      +/-   ##
============================================
- Coverage     68.65%   67.21%   -1.45%     
+ Complexity      120        2     -118     
============================================
  Files          3073     1507    -1566     
  Lines        146471    62862   -83609     
  Branches      24152     9169   -14983     
============================================
- Hits         100566    42251   -58315     
+ Misses        36853    16453   -20400     
+ Partials       9052     4158    -4894     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM requested a review from AlbumenJ February 16, 2023 03:35
@AlbumenJ AlbumenJ merged commit 9497802 into apache:3.2 Feb 26, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
* ADD dubbo-maven-plugin

* add dubbo-maven-plugin module

Signed-off-by: crazyhzm <[email protected]>

* fix license and compiler error

Signed-off-by: crazyhzm <[email protected]>

* fix license and ci error

Signed-off-by: crazyhzm <[email protected]>

* fix ci error

Signed-off-by: crazyhzm <[email protected]>

* Remove proxy-config, hard code

Signed-off-by: crazyhzm <[email protected]>

* ignoredModulesInDubboAll

Signed-off-by: crazyhzm <[email protected]>

* throw exception for generated adaptive class sources

Signed-off-by: crazyhzm <[email protected]>

---------

Signed-off-by: crazyhzm <[email protected]>
Co-authored-by: Albumen Kevin <[email protected]>
@CrazyHZM CrazyHZM deleted the feat/dubbo-maven-plugin branch May 17, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants