Skip to content

Observability task: registration center #11493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlbumenJ merged 69 commits into from
Feb 25, 2023
Merged

Observability task: registration center #11493

AlbumenJ merged 69 commits into from
Feb 25, 2023

Conversation

@wxbty
Copy link
Member

@wxbty wxbty commented Feb 6, 2023 •
edited
Loading

Issue Number: close #11146
注册中心-可观测性
与default实现上有些差异，主要几点：
1、两级事件机制，埋点事件->注册中心事件->注册监听器->统计数据， listener从spi加载
default是统计完数据后发一个事件
2、去掉MetricsStatHandler，这个应该没有必要，increase 等自增功能是数据聚合类职能
3、统计项的遍历注册只做一次（initDataStructure），后续从集合中处理获取数据，定义内部数据容器来处理差异行为

4、Collector注册在ApplicationModel级别，需要application.yml的配置对应

@songxiaosheng
Copy link
Member

songxiaosheng commented Feb 7, 2023

@wxbty

please fix unit test error:
image

@songxiaosheng songxiaosheng mentioned this pull request Feb 8, 2023
Closed
@wxbty
Copy link
Member Author

wxbty commented Feb 9, 2023

@wxbty

please fix unit test error: image

done

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #11493 (56566a8) into 3.2 (62509fb) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11493      +/-   ##
============================================
- Coverage     69.75%   69.64%   -0.12%     
+ Complexity      105        2     -103     
============================================
  Files          1573     1392     -181     
  Lines         84223    60275   -23948     
  Branches      15012     8929    -6083     
============================================
- Hits          58750    41978   -16772     
+ Misses        20573    14147    -6426     
+ Partials       4900     4150     -750
Impacted Files Coverage Δ
...dubbo/rpc/cluster/directory/AbstractDirectory.java
...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java
...in/java/org/apache/dubbo/config/MetricsConfig.java
...ubbo/config/deploy/DefaultApplicationDeployer.java
...ache/dubbo/metrics/collector/MetricsCollector.java
...o/metrics/event/GlobalMetricsEventMulticaster.java
...o/metrics/event/SimpleMetricsEventMulticaster.java
...apache/dubbo/metrics/listener/MetricsListener.java
...a/org/apache/dubbo/metrics/model/MethodMetric.java
...ava/org/apache/dubbo/metrics/model/MetricsKey.java
... and 2955 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wxbty wxbty changed the title Feature/registry Observability task: registration center related index data Feb 17, 2023
@wxbty wxbty changed the title Observability task: registration center related index data Observability task: registration center Feb 17, 2023
@wxbty wxbty requested review from AlbumenJ and songxiaosheng and removed request for AlbumenJ and songxiaosheng February 17, 2023 14:01
AlbumenJ
AlbumenJ approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

songxiaosheng
songxiaosheng approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng mentioned this pull request Feb 21, 2023
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

59.2% 59.2% Coverage
11.4% 11.4% Duplication

AlbumenJ
AlbumenJ approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit c041fa1 into apache:3.2 Feb 25, 2023
@wxbty wxbty deleted the feature/registry branch February 25, 2023 11:53
@wxbty wxbty mentioned this pull request Feb 25, 2023
Merged
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
@mytang0
Merge remote-tracking branch 'origin/3.2' into refactor-sliding-window
e217122 
* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
@conghuhu conghuhu mentioned this pull request Mar 7, 2023
Open
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
@wxbty @lcb11
Observability task: registration center (apache#11493)
392e794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@songxiaosheng songxiaosheng songxiaosheng approved these changes

+1 more reviewer

@mytang0 mytang0 mytang0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@wxbty @songxiaosheng @codecov-commenter @AlbumenJ @mytang0