test: Add unit-test for Volume Core's DetachVolume method #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We found this is your first time to contribute to Pouch, @panzaiyu |
panzaiyu
changed the title
HusterWan
reviewed
Jul 24, 2018
storage/volume/core_test.go
Outdated
| } | ||
|
|
||
| //Mock data for TestDetachVolume | ||
| func mockVolumeCore(root string) (*Core, error) { |
Contributor
There was a problem hiding this comment.
this function is ok, but we already has a function to NewCore: createVolumeCore
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
+ Coverage 56.3% 56.38% +0.07%
==========================================
Files 200 200
Lines 15657 15659 +2
==========================================
+ Hits 8816 8829 +13
+ Misses 5745 5738 -7
+ Partials 1096 1092 -4
|
HusterWan
reviewed
Jul 24, 2018
storage/volume/core_test.go
Outdated
|
|
||
| //create volume core | ||
|
|
||
| core, err := mockVolumeCore(dir) |
Contributor
There was a problem hiding this comment.
Please use createVolumeCore
Contributor
|
@panzaiyu please update the code as comment, thanks a lot. |
Collaborator
|
@panzaiyu Thanks for your contribution. 🍻 |
Contributor
|
lgtm |
pouchrobot
added
the
LGTM
allencloud
changed the title
This was referenced Jul 24, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add unit-test for Volume Core's DetachVolume method
Ⅱ. Does this pull request fix one issue?
fixes #1761
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews