Skip to content

Conversation

@lzpawell
Copy link

Ⅰ. Describe what this PR did

TestDetachVolume

Ⅱ. Does this pull request fix one issue?

fix #1761

Ⅲ. Describe how you did it

I add some code for testing method Core.DetachVolume
I make two test cases in this issue
case 1 is for testing condition that detach volume not exists or not attached
case 2 is for testing condition that detach an attached volume

Ⅳ. Describe how to verify it

the run Test cases an it can pass

Ⅴ. Special notes for reviews

In my work, I found that the parameter string[] labels is never used in the code, I suspect that is a bug

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @lzpawell
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

@lzpawell Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @lzpawell
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @lzpawell
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@YaoZengzeng
Copy link
Contributor

#1824 which has been merged solves the same problem with this PR, so close it.

Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for DetachVolume

4 participants