Skip to content

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 24, 2018

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1761

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

@SeaRise Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @SeaRise
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @SeaRise
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@YaoZengzeng
Copy link
Contributor

#1824 which has been merged solves the same problem with this PR, so close it.

Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for DetachVolume

3 participants