Skip to content

Conversation

@jiapengcs
Copy link
Contributor

Ⅰ. Describe what this PR did

Add unit-test for Volume Core's DetachVolume method which locate on storage/volume/core.go.

Ⅱ. Does this pull request fix one issue?

fixes #1761

Ⅲ. Describe how you did it

implement function TestDetachVolume in core_test.go

Ⅳ. Describe how to verify it

unit test, run go test -test.run DetachVolume

Ⅴ. Special notes for reviews

None

@pouchrobot
Copy link
Collaborator

@jiapengcs Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @jiapengcs
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @jiapengcs
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@YaoZengzeng
Copy link
Contributor

#1824 which has been merged solves the same problem with this PR, so close it.

Thanks for your work !

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f369ee7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1890   +/-   ##
=========================================
  Coverage          ?   56.49%           
=========================================
  Files             ?      200           
  Lines             ?    15659           
  Branches          ?        0           
=========================================
  Hits              ?     8846           
  Misses            ?     5722           
  Partials          ?     1091
Flag Coverage Δ
#critest 33.54% <ø> (?)
#integrationtest 37.65% <ø> (?)
#unittest 20.59% <ø> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for DetachVolume

4 participants