setPoseTarget to the underlying object3D (fix #3728, #3748, #3771) #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Oct 22, 2018
src/core/scene/a-scene.js
Outdated
| renderer = this.renderer = new THREE.WebGLRenderer(rendererConfig); | ||
| renderer.setPixelRatio(window.devicePixelRatio); | ||
| renderer.sortObjects = false; | ||
| renderer.vr.setPoseTarget(this.camera); |
|
Can you add |
stlewis
changed the title
dmarcos
reviewed
Oct 22, 2018
| renderer = this.renderer = new THREE.WebGLRenderer(rendererConfig); | ||
| renderer.setPixelRatio(window.devicePixelRatio); | ||
| renderer.sortObjects = false; | ||
| renderer.vr.setPoseTarget(this.camera); |
There was a problem hiding this comment.
We need this line but it has to be renderer.vr.setPoseTarget(this.camera.el.object3D); to be consistent with the one below
There was a problem hiding this comment.
👍 Put a guard on it, everything is functioning properly.
stlewis
force-pushed
the
fix-go-camera-height-bug
branch
from
cac00dc to
14d9ca4
Compare
dmarcos
reviewed
Oct 22, 2018
src/core/scene/a-scene.js
Outdated
| renderer.setPixelRatio(window.devicePixelRatio); | ||
| renderer.sortObjects = false; | ||
| renderer.vr.setPoseTarget(this.camera); | ||
| if (this.camera) renderer.vr.setPoseTarget(self.camera.el.object3D); |
dmarcos
reviewed
Oct 22, 2018
src/core/scene/a-scene.js
Outdated
| renderer.setPixelRatio(window.devicePixelRatio); | ||
| renderer.sortObjects = false; | ||
| renderer.vr.setPoseTarget(this.camera); | ||
| if (this.camera) renderer.vr.setPoseTarget(this.camera.el.object3D); |
There was a problem hiding this comment.
Missing curly braces: if (this.camera) { renderer.vr.setPoseTarget(this.camera.el.object3D); }
|
Thanks! Congrats on your first contribution 🏅 |
This was referenced Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes #3728 and #3748
Changes proposed: