Skip to content

setPoseTarget to the underlying object3D (fix #3728, #3748, #3771) #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2018
Merged

setPoseTarget to the underlying object3D (fix #3728, #3748, #3771) #3820

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d9ca4
setPoseTarget to the underlying object3D
stlewis Oct 22, 2018
8fc87a7
`this` instead of `self`
stlewis Oct 22, 2018
bdc3810
Curly braces
stlewis Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/scene/a-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,9 @@ module.exports.AScene = registerElement('a-scene', {
renderer = this.renderer = new THREE.WebGLRenderer(rendererConfig);
renderer.setPixelRatio(window.devicePixelRatio);
renderer.sortObjects = false;
renderer.vr.setPoseTarget(this.camera);
Copy link
Member

@dmarcos dmarcos Oct 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this line but it has to be renderer.vr.setPoseTarget(this.camera.el.object3D); to be consistent with the one below

Copy link
Contributor Author

@stlewis stlewis Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Put a guard on it, everything is functioning properly.

if (this.camera) renderer.vr.setPoseTarget(self.camera.el.object3D);
Copy link
Member

@dmarcos dmarcos Oct 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.camera.el.object3D

this.addEventListener('camera-set-active', function () {
renderer.vr.setPoseTarget(self.camera);
renderer.vr.setPoseTarget(self.camera.el.object3D);
});
loadingScreen.setup(this, getCanvasSize);
},
Expand Down