update @embroider/test-setup to fix CI #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
fix-embroider
branch
2 times, most recently
from
e72c267 to
3db27c6
Compare
Contributor
Author
|
Using @Pixelik's suggestion in #733 (comment) brings the failing tests down from 9 to 5 which is progress I guess 🤷 |
mansona
force-pushed
the
fix-embroider
branch
from
3db27c6 to
f06525a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@embroider/test-setuppackage was very out of date so we really couldn't expect theembroider-safeorembroider-optimisedtests to pass without updating it 👍