We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 75d558c commit 3db27c6Copy full SHA for 3db27c6
1 file changed
addon/-private/options.js
@@ -1,5 +1,4 @@
1
import EmberObject, { get } from '@ember/object';
2
-import { isDescriptor } from '../utils/utils';
3
4
const { keys } = Object;
5
const OPTION_KEYS = '__option_keys__';
@@ -18,11 +17,7 @@ export default class Options {
18
17
const optionKeys = keys(options);
19
const createParams = { [OPTION_KEYS]: optionKeys, model, attribute };
20
21
- // If any of the options is a CP, we need to create a custom class for it
22
- if (optionKeys.some((key) => isDescriptor(options[key]))) {
23
- return OptionsObject.extend(options).create(createParams);
24
- }
25
-
26
- return OptionsObject.create(createParams, options);
+ // we have to extend here in case anyone passes options that have computedProperties.
+ return OptionsObject.extend(options).create(createParams);
27
}
28
0 commit comments