Skip to content

Commit e72c267

Browse files
committed
always use extend for Internal OptionsObject
1 parent 75d558c commit e72c267

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

addon/-private/options.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@ export default class Options {
1818
const optionKeys = keys(options);
1919
const createParams = { [OPTION_KEYS]: optionKeys, model, attribute };
2020

21-
// If any of the options is a CP, we need to create a custom class for it
22-
if (optionKeys.some((key) => isDescriptor(options[key]))) {
23-
return OptionsObject.extend(options).create(createParams);
24-
}
25-
26-
return OptionsObject.create(createParams, options);
21+
// we have to extend here in case anyone passes options that have computedProperties.
22+
return OptionsObject.extend(options).create(createParams);
2723
}
2824
}

0 commit comments

Comments
 (0)