Merged
Conversation
The tag can't be resolved by Jitpack so use the commit-hash instead
Co-Authored-By: Thompson3142 <[email protected]>
* IcePick fails on Java 21 (default in Android Studio 2024.2) * Bridge is the most modern alternative that is currently available. It is backed by ``Android-State`` and can be configured with various frameworks * In the long term this should be replaced with something better
|
Stypox
approved these changes
Oct 23, 2024
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Sorry for the annoyances and thank you for fixing them! I tested state saving on my phone by setting "background process limit = 0" in developer settings, and it worked normally.
This was referenced Oct 23, 2024
Closed
Closed
ShareASmile
added
bug
Member
Author
|
Further note: Also had the debug app installed on my phone and did some "casual" testing today. |
Contributor
|
Can confirm, also works for me (after upgrading to ladybug) 👍 |
7 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I checked out NewPipe with the latest version of Android Studio (2024.2) and it no longer compiles.
This is not good as the default (
dev) branch should ALWAYS compile.New developers may run into problems immediately when checking out the code and give up instantly.
Here is a list of encountered and fixed problems:
llegalAccessError: superclass access check failed: class org.jetbrains.kotlin.kapt3.base.javac.KaptJavaCompilerTesting:
Open a view/component where IcePick was removed (e.g. "About & FAQ") and rotate the device → No crash or similar should occur
This PR supersedes the following PRs:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence