Replaced symlink (causing issues with windows) with the file the symlink was pointing to#11482
Closed
Thompson3142 wants to merge 2 commits intoTeamNewPipe:devfrom
Closed
Replaced symlink (causing issues with windows) with the file the symlink was pointing to#11482Thompson3142 wants to merge 2 commits intoTeamNewPipe:devfrom
Thompson3142 wants to merge 2 commits intoTeamNewPipe:devfrom
Conversation
…ink was pointing to
Contributor
Author
|
If this change should be documented in some way to avoid errors when editing only one of the two existing files let me now. (Also my first pull request so be gentle :) ) |
Contributor
Author
|
Realized i copied a different file than the one which was actually referenced by the symlink, sorry for the confusion. |
litetex
approved these changes
Oct 21, 2024
ShareASmile
added
bug
Member
|
Superseded by #11636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When the git repo is cloned from a windows machine it does not (always) recognize symlinks. I simply copied the contents of the file the symlink was pointing to, into the file with the symlink.
Fixes the following issue(s)
Fixes #10963
Due diligence