Migrate image loading from Picasso to Coil#11238
Merged
Stypox merged 13 commits intoTeamNewPipe:refactorfrom Aug 7, 2024
Merged
Migrate image loading from Picasso to Coil#11238Stypox merged 13 commits intoTeamNewPipe:refactorfrom
Stypox merged 13 commits intoTeamNewPipe:refactorfrom
Conversation
This was referenced Jul 5, 2024
Stypox
requested changes
Jul 21, 2024
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Sorry for taking so long to review :-(
Looks mostly good to me, thank you!
app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/util/external_communication/ShareUtils.java
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Show resolved
Hide resolved
|
5 tasks
Contributor
|
Is there any reason it lend only to refactor? |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence