Migrate comment fragments to Jetpack Compose

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Update the Compose dependencies to their latest versions.
• Add the Compose library for Coil to handle image loading.
• Add the LazyColumnScrollbar library to display scrollbars in Compose.
• Migrate the comments to use Jetpack Compose and replace the comment replies fragment with a bottom sheet dialog.
• Handle loading the comments and comment replies using the Paging library and a view model.

Before/After Screenshots/Screen Record

Before
Comments	Comment replies

After (initial design)
Comments	Comment replies	Expanded comment replies

After (improved design)
Comments	Comment replies	Expanded comment replies

Screen_recording_20240708_162549.mp4

Relies on the following changes

• Migrate image loading from Picasso to Coil #11238

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[Stypox]

I pushed a few commits:

• redesigned the layouts, see comparison in PR body
• merge with refactor to include build fixes by litetex
• fix paging skipping first page of comments
• handle unknown values without showing -1 in various places
• you can test nested replies and unknown comment and like counts in this peertube video: https://share.tube/w/vxu4uTstUBAUromWwXGHrq
• you can test hearted and pinned comment in this youtube video: https://www.youtube.com/watch?v=Wf1th3vi53U
• TODO: what should happen when the user clicks on a channel while inside of the comment replies dialog? Currently the channel does open, but only behind the bottom sheet, which is quite strange and difficult to notice. I would propose just lowering the bottom sheet, but not closing it to avoid accidental clicks on channel icons to close the view and forcing the user to scroll back to the original location to continue reading replies.
• TODO: use Icons.Default.* instead of vector icons
• TODO: create utility function to copy to clipboard from inside of a composable function

[sonarqubecloud]

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Stypox]

Thank you! I implemented the TODOs in my previous comment.

The review comments I left here are things to do in future PRs.

[Stypox]

Note: reimplementing Description -> AnnotatedString is going to be a tough task, considering how complicated TextLinkifier is: https://github.com/TeamNewPipe/NewPipe/blob/9d6ac67c46a6cc55e03dec0599d8070f7430098d/app/src/main/java/org/schabi/newpipe/util/text/TextLinkifier.java

[Stypox]

An error panel should be created to handle all of these cases and allow retrying, reporting and opening in browser.

[AudricV]

Here is some general feedback to be added to my review comments:

• the difference between the two loading spinners is a bit disturbing, the new one for comments doesn't seem to match Material Design style;
• it would be great if the replies only prevent interacting with comments and not all content (i.e. comment drawers cannot be shown outside of the comments view).

[AudricV]

The app crashes when trying to load comment replies when being offline after comments have been loaded with a network connection at this exact line (it should also happen on comment continuations). This must be fixed.

[AudricV]

There is no cache in the comment replies fetching, causing the app to reload them each time the device is rotated or a switch between the description content view tab and the comments one is done. This regression must be fixed.

[Profpatsch]

I created issues for the remaining post-review comments

[Stypox]

Now errors in the comments make the app crash completely (https://soundcloud.com/user-722618400/a-real-playa):

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: GB
• Content Language: en-GB
• App Language: en_GB
• Service: none
• Version: 0.27.2
• OS: Linux Android 13 - 33

Crash log

java.lang.IllegalArgumentException: Page doesn't contain an URL
	at org.schabi.newpipe.extractor.services.soundcloud.extractors.SoundcloudCommentsExtractor.getPage(SoundcloudCommentsExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getMoreItems(CommentsInfo.java:79)
	at org.schabi.newpipe.paging.CommentsSource$load$info$1.invokeSuspend(CommentsSource.kt:23)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:113)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:823)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [LazyStandaloneCoroutine{Cancelling}@16d25a5, Dispatchers.Main.immediate]

---

[Profpatsch]

I’ll add an issue and mark it high priority