Migrate image loading from Picasso to Coil#11201
Merged
Isira-Seneviratne merged 11 commits intoTeamNewPipe:refactorfrom Jul 3, 2024
Merged
Migrate image loading from Picasso to Coil#11201Isira-Seneviratne merged 11 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne merged 11 commits intoTeamNewPipe:refactorfrom
Conversation
5 tasks
Collaborator
Thank you for thinking of low-RAM devices. ❤️ |
Member
Author
I initially enabled it for all devices, but changed that as the documentation recommends it for low-RAM devices only. |
Collaborator
|
What's the threshold, BTW? 3GB? |
Member
Author
It depends on the device configuration, according to the documentation, but it's generally 1 GB. |
Isira-Seneviratne
force-pushed
the
Coil
branch
2 times, most recently
from
c924175 to
1747c22
Compare
|
Isira-Seneviratne
added a commit
that referenced
this pull request
Jul 5, 2024
This reverts commit 73e3a69.
Isira-Seneviratne
added a commit
to Isira-Seneviratne/NewPipe
that referenced
this pull request
Jul 22, 2024
* Load notification icons using Coil * Migrate to Coil from Picasso * Clean up Picasso leftovers * Enable RGB-565 for low-end devices * Added Coil helper method * Add annotation * Simplify newImageLoader implementation * Use Coil's default disk and memory cache config * Enable crossfade animation * Correct method name * Fix thumbnail not being displayed in media notification
Isira-Seneviratne
added a commit
to Isira-Seneviratne/NewPipe
that referenced
this pull request
Jul 22, 2024
* Load notification icons using Coil * Migrate to Coil from Picasso * Clean up Picasso leftovers * Enable RGB-565 for low-end devices * Added Coil helper method * Add annotation * Simplify newImageLoader implementation * Use Coil's default disk and memory cache config * Enable crossfade animation * Correct method name * Fix thumbnail not being displayed in media notification
Isira-Seneviratne
added a commit
to Isira-Seneviratne/NewPipe
that referenced
this pull request
Jul 22, 2024
* Load notification icons using Coil * Migrate to Coil from Picasso * Clean up Picasso leftovers * Enable RGB-565 for low-end devices * Added Coil helper method * Add annotation * Simplify newImageLoader implementation * Use Coil's default disk and memory cache config * Enable crossfade animation * Correct method name * Fix thumbnail not being displayed in media notification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence