Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Feb 18, 2019

Included changes (https://github.com/StackStorm/st2/pulls?q=is%3Apr+is%3Aclosed+milestone%3A2.10.2):

Kami and others added 30 commits February 18, 2019 09:44
1. Mitigate / avoid race when calling add_file() before tailer has been
initialized
2. Fix a bug with failing to dispatch a trigger due to code using
invalid trigger type reference (it uses trigger ref instead of trigger
type ref)
reference and not trigger type reference is passed to it.
indefinetly if connection to RabbitMQ cannot be established.

Also add errback which logs an actual error when trying to re-establish
a connection.
NOTE: Security vulnerability doesn't affect our code because we already
use yaml.safe_load everywhere, but it's still good to update.
since this can potentially result in too many unique metrics.
when sys.prefix is relative (e.g. when calling ./tools/launchdev.sh
script outside of tools directory or similar).
(https://blog.hackeriet.no/cve-2019-6690-python-gnupg-vulnerability/).

NOTE: This security vulnerability doesn't affect us because we only this
library in an isolated scenario (encrypting debug tarball without using
a passphrase).
handle unicode (utf-8) data.

Previously we didn't correctly convert string to bytes before padding
data which resulted in incorrectly padded data (incorrect length) so the
actual encryption step failed.

Thanks to @dswebbthg for reporting this issue.

Resolves #4513.
"pack" attribute to the execution context.

If we don't add that, {{ config_context }} won't work correctly for
default parameter values for action executions which are scheduled as
part of an Orquesta workflow.
sure also also add "pack" attribute to LiveActionDB.context attribute
inside "create_request" function.

We already add it in RunnerContainer.dispatch(), but that's not the best
place since some tests don't call that method so that value won't be
present.
default parameter values works for executions scheduled via Orquesta
workflow.
m4dcoder and others added 15 commits February 18, 2019 10:20
Add retries in the scheduler handler to temporarily handle DB connection failures. Refactor how threads exit for the process to return proper code.
entrypoint exceptions.

NOTE: Tests currently fail because issue hasn't been fully fixed yet.
Regenerated the sample st2 config with the scheduler retry configuration options.
Add a unit test to cover failure in the handler cleanup. This should signal the run method to also pause and exit the scheduler handler process.
Add unit tests to cover the retries in the run and cleanup in the scheduler handler.
Add or move the parsing of test configs to the top of affected test modules and make sure the scheduler default config options do not conflict with test configs.
Update orquesta to version 0.4 to include fixes on CPU usage, interpretation of quoted strings and boolean values in shorthand publish, with items variable with the word "in" that conflict with syntax, and other docs updates.
they get large enough.

Also use larger poll interval.
@Kami Kami added this to the 2.10.2 milestone Feb 18, 2019
@Kami
Copy link
Member Author

Kami commented Feb 18, 2019

NOTE: Circle CI packages build will keep failing until this is merged in v2.10 branch and a new build is triggered using st2-packages v2.10 branch.

The reason for that is that this PR is using st2-packages master where cloudslang and old winexe based runners have been removed (but they are still present in v2.10 branch).

@Kami Kami merged commit fc67533 into v2.10 Feb 18, 2019
@arm4b arm4b deleted the v2102_changes branch February 18, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants