Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Jan 24, 2019

This pull request updates instrumentation middleware so we don't submit any request metrics for all the "get one" API endpoints.

Previously we manually excluded some of the "most offending" API endpoints (get a single execution, etc.), but it's the safest to simply skip submitting metrics for all of "get one" API endpoints.

Submitting metrics for those endpoints results in too many unique metrics which is an anti-pattern and doesn't scale.

since this can potentially result in too many unique metrics.
@Kami Kami added this to the 2.10.2 milestone Jan 24, 2019
Kami added 2 commits January 24, 2019 19:40
when sys.prefix is relative (e.g. when calling ./tools/launchdev.sh
script outside of tools directory or similar).
@Kami
Copy link
Member Author

Kami commented Jan 24, 2019

I pushed another small (unrelated) fix for sys.prefix assertion.

In some scenarios (e.g. when launchdev.sh was started outside of tools directory), sys.prefix will be set to a relative path and assertion will trigger because get_python_lib function always returns an absolute path.

@Kami Kami requested a review from bigmstone January 25, 2019 16:24
@Kami Kami requested a review from blag January 29, 2019 11:41
@Kami Kami merged commit 19bda9d into master Jan 30, 2019
@Kami Kami deleted the dont_submit_metrics_for_get_one_endpoints branch January 30, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants