Fix accidental regression in pylint Makefile check #4540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a couple of lines were accidentely removed in dc26170 and since then we didn't perform any pylint checks on StackStorm components and runners code.
Member
Author
|
Per discussion with @LindsayHill on Slack - we should also enable some other non-error checks like "literal-comparison", etc. The problem is that right now we only enable "error" checks (there is too much noise and false positives with many non fatal error messages). If we want to enable a single "literal-comparison" check which is part of warning / refactoring category we need to enable all other warnings and refactor messages as well and then explicitly disable all that we are not interested in. This will take a wile (exclude list will be long) and I will do it in a different PR in the future. |
Contributor
|
LGTM but I guess you need to get all the CIs to pass here. |
m4dcoder
approved these changes
Feb 8, 2019
Contributor
m4dcoder
left a comment
m4dcoder
left a comment
There was a problem hiding this comment.
Conditional on getting CIs to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a couple of lines were accidentely removed in dc26170 and since then we didn't perform any pylint checks on StackStorm components and runners code 🤦♂️.