-
Notifications
You must be signed in to change notification settings - Fork 200
One Click Checkout #3391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
syadupathi-sf
wants to merge
105
commits into
develop
Choose a base branch
from
feature/1cc_payments
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
One Click Checkout #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* W-19084772 Remove review order step in one click checkout * skip changelog * re work to place the Place Order button according to the latest figma * fix button stickiness
Add a new user registration ("Save for Future Use") box in the 1CC layout. After placing order with this option checked, account registration will be initiated.
Add saved phone number to the 1CC user registration flow.
Add saved shipping address to the 1CC user registration flow.
* Initial push for the demo * fix guest user flow to not show the otp modal * W-18927151 Trigger OTP modal * Reverting configuration * minor * skip changelog * fix translations * minor - remove comment * address code review comments * fix the spinner
* W-19084772 Remove review order step in one click checkout * skip changelog * re work to place the Place Order button according to the latest figma * fix button stickiness
Add a new user registration ("Save for Future Use") box in the 1CC layout. After placing order with this option checked, account registration will be initiated.
Add saved phone number to the 1CC user registration flow.
Add saved shipping address to the 1CC user registration flow.
* Initial push for the demo * fix guest user flow to not show the otp modal * W-18927151 Trigger OTP modal * Reverting configuration * minor * skip changelog * fix translations * minor - remove comment * address code review comments * fix the spinner
…e-shipping-bugfix Open OTP modal when user clicks proceed to shipping address
* W-19121709 Saved payment instrument * skip changelog * lint fix * fix tests and other issues * revert some of the unnecessary changes * reverting some more changes
…nly-myaccount @W-19444204 email input readonly in myaccount
* W-19444570 add payment instrument * Make sure create-mobify-app-dev.js works as intended Bumping up the -dev versions make sure that all packages have versions that have NOT been published to npm yet. Previously we accidentally published `3.12.0-dev` to npm. --------- Co-authored-by: Vincent Marta <[email protected]>
* W-19444575 Delete payment instrument * address code review comments * lint fixes
Signed-off-by: syadupathi-sf <[email protected]>
* W-19548614 Revert proxy changes for passwordless login * add test for coverage
* Fixes for preselecting SPM and add spm in my account * removed invalid comment * reverted accidental commit to _app-config * reverting accidental commit to ssr.js * reverting accidental commit to default.js * removed commented test * Fixing autoselect of SPM * Localized the label for the view all spm button * linting fixes * fixed the conditional logic to show or hide the show all button
* W-19751635 UX changes for saved payment methods in checkout * clean up code * address code review comments * address more code review comments * adding translations * fix lint errors * fix test failure
Mkosak.w 19689069.prev rel iso
…yment-method-myaccount @W-19444592 hide add payment method button in myaccount
…yment-method-myaccount-2 Fixed loading and error states of the shopper configuration API
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…s' into feature/1cc_payments
* W-19797935 Save payment method for future use * additional tests * fix the sabed payment logic by eliminating effects from prev design * address code review comments * minor * fix lint * tests * translations * lint fix * minor
* W-19444573 Set default payment instrument * choose default payment on checkout * address code review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
skip changelog
Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization