Open OTP modal when user clicks proceed to shipping address #3243
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
| : `${appOrigin}${passwordlessConfigCallback}` | ||
|
|
||
| // Reset guest checkout flag when user registration status changes | ||
| useEffect(() => { |
There was a problem hiding this comment.
I don't believe this was necessary and the usage of useEffect causes unnecessary re-renders
sf-mkosak
force-pushed
the
mkosak.W-19525615.otp-continue-shipping-bugfix
branch
from
22cce0d to
6d2724e
Compare
| } = useDisclosure() | ||
|
|
||
| // Helper function to validate email format | ||
| const isValidEmail = (email) => { |
There was a problem hiding this comment.
I can see this being needed in another component so I just moved it to a util that has it's own dedicated testing
| expect(screen.getByText('Please enter a valid email address.')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| test('validates different types of valid emails correctly', async () => { |
There was a problem hiding this comment.
The tests validates email format on form submission and 'validates email is required on form submission' validates the case an invalid email is submitted. renders continue button for guest checkout and others exercise a valid email so we have coverage of both scenarios at the component level. For the specific email validation I added lots of test cases specifically in the utility
sf-mkosak
requested review from
dannyphan2000,
kumaravinashcommercecloud and
syadupathi-sf
sf-mkosak
merged commit fbcd5f5
into
SalesforceCommerceCloud:feature/1cc_payments
4 participants
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization