Fix PMP profile handling and rendering for empty PMP display names#495
Merged
7w1 merged 4 commits intoSableClient:devfrom Mar 23, 2026
Merged
Fix PMP profile handling and rendering for empty PMP display names#4957w1 merged 4 commits intoSableClient:devfrom
7w1 merged 4 commits intoSableClient:devfrom
Conversation
…nd don't include a fallback if the display name is empty
… addition of fallback text
…es if the name is unset or whitespace only
7w1
approved these changes
Mar 23, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * `Ctrl + K` search menu is now context aware and lists the current space's rooms at the top. ([#499](#499) by @7w1) * Add knocking support when attempting to join a room from the directory, an address, a room mention, or space hierarchy, as well as text command support for knocking. Also improves rendering for knock notifications in rooms. ([#470](#470) by @polyjitter) * Add Android/iOS PWA-specific icon variants. ([#473](#473) by @Septicity) * Add support for youtube embeds. ([#497](#497) by @thundertheidiot) * Add sidebar three dot menu for quick access to related settings ([#474](#474) by @wolterkam) * Replies that mention the OP are now indicated by the OP username being prefixed with @ ([#465](#465) by @mini-bomba) * Made pin events show a tally of the messages that are pinned. ([#462](#462) by @nushea) ### Improve multiline composer and voice recording ([#476](#476) by @hazre) - Add a multiline composer layout for longer drafts. - Keep the voice recorder between composer actions in multiline mode. - Show the recorder inside the composer on mobile while recording. - Prevent the composer from expanding when recording starts. - Make the recorder footer and waveform fit better across screen sizes. - Let interrupted mobile recording gestures still stop correctly. - Stabilize wrap detection around edge cases like narrow widths and trailing spaces. ## Fixes * Added error messages provided by homeserver to unknown login errors. ([#496](#496) by @7w1) * Ensure new updates always reload the page properly. ([#502](#502) by @7w1) * Removed the blocked users moved notice from notifications setting page. ([#490](#490) by @7w1) * Fix recieved encrypted message per-message profiles not triggering rerenders. ([#464](#464) by @7w1) * Add `.m4a` files as a recognized audio type. ([#472](#472) by @henk717) * Fix messages disappearing from rooms after reconnects and timeline resets. ([#478](#478) by @hazre) * Fix Camera being enabled by default even when the client has it off pre joining in browsers that permit the video (Electron/Tauri as examples). ([#485](#485) by @Rawrington) * Fix cinny-dark-theme link colors being too dark ([#469](#469) by @Elec3137) * Fix "Default" menu item height in room notification switcher. ([#466](#466) by @polyjitter) * fix the issue of empty displaynames of a persona, causing an empty fallback message, it will now ommit the fallback, if the name is empty or only consists of whitespace ([#495](#495) by @dozro) * Fixed an Android issue where recording a voice message with headphones could leave audio stuck in low-quality mode until the app was restarted. ([#476](#476) by @hazre) * Fixed voice message scrubbing/seeking on Firefox by switching the recorder from WebM (no seek index) to Ogg/Opus. ([#476](#476) by @hazre) * fixes touchpad zooming behaviour ([#481](#481) by @integralfunction) * Fixes width mismatch for the call chat view. ([#460](#460) by @polyjitter) * Fix messages sent from sable showing wrong on other client(s) ([#468](#468) by @nushea) ## Documentation * Updated PR template and CONTRIBUTING.md to add AI disclosure requirement. ([#456](#456) by @Rosy-iso)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes that whitespace only, or empty display names of per-message-profiles resulting in display-names in the event being unset and the fallback-string not being added to the body.
It also unsets the
avatar_urlif the avatar is not set. And internally made the displayname an optional field. Only theidis now an required field for the beeper pmp.It also changes the message rendering, by removing the "via"-part if the name is unset.
Type of change
Checklist:
AI disclosure:
No AI was used for my changes