Feat: Pin event styling and coloring events in timeline#462
Feat: Pin event styling and coloring events in timeline#4627w1 merged 9 commits intoSableClient:devfrom
Conversation
|
Imo it seems a little odd to have two pin icons for every pin event? It just feels a little cluttered. |
I would love to find a better alternative but this is what compromise we could best think of in https://matrix.to/#/!a6sXbRuOyyc7MKutmy:sable.moe/$3U5-kgbS-OAeX8dvDCPKxcd936wnFwi-DkdiF_v5kVs?via=matrix.org&via=unredacted.org&via=4d2.org maybe it could be made an animation or sth? but then it would still have the issue after that is done, so idk what could be put instead |
Rosy-iso
left a comment
There was a problem hiding this comment.
UI wise, the way the pin idea is implemented looks good. Though the 📌+ and 📌- icons seem a little...redundant? the message above already says if it's being pinned or unpinned (and pin events arent something that happens often) and there's another pin icon just to the left already...I would personally remove the 📌+ and 📌- but I'm also not full on against it, open to discussion there.
For the colored names, I think it's a nice change that adds some color to the UI which is certainly welcomed...but why is it alongside the pin event? These two things have very little correlation... It's fine here since it's highly likely that both things could be merged but I'd personally keep PRs precise to a specific scope (though, this is outside my area of jurisdiction, its just my opinion)
the reason why they are there is because you are allowed to have multiple pins in one event, so youd need to tell which message got added and which got removed, and just having the +/- would make it look even more out of place so thats why i have ended up on that but if there are any other ideas on how i could make it obvious the list is related to the parent event and show on each element whether it has been added or removed id love to find a better option
true, i put them into different commits but i shouldve put them into different prs and like honestly the only reason they arent 2 different prs is that i made both changes in the same period of time, but from a logical standpoint they should be 2, and i should try to restrict the scope of my prs whenever i send them to be per feat/fix |
I seee, that makes a lot more sense now yeah, that works! |
794dddd to
fcbb54a
Compare
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * `Ctrl + K` search menu is now context aware and lists the current space's rooms at the top. ([#499](#499) by @7w1) * Add knocking support when attempting to join a room from the directory, an address, a room mention, or space hierarchy, as well as text command support for knocking. Also improves rendering for knock notifications in rooms. ([#470](#470) by @polyjitter) * Add Android/iOS PWA-specific icon variants. ([#473](#473) by @Septicity) * Add support for youtube embeds. ([#497](#497) by @thundertheidiot) * Add sidebar three dot menu for quick access to related settings ([#474](#474) by @wolterkam) * Replies that mention the OP are now indicated by the OP username being prefixed with @ ([#465](#465) by @mini-bomba) * Made pin events show a tally of the messages that are pinned. ([#462](#462) by @nushea) ### Improve multiline composer and voice recording ([#476](#476) by @hazre) - Add a multiline composer layout for longer drafts. - Keep the voice recorder between composer actions in multiline mode. - Show the recorder inside the composer on mobile while recording. - Prevent the composer from expanding when recording starts. - Make the recorder footer and waveform fit better across screen sizes. - Let interrupted mobile recording gestures still stop correctly. - Stabilize wrap detection around edge cases like narrow widths and trailing spaces. ## Fixes * Added error messages provided by homeserver to unknown login errors. ([#496](#496) by @7w1) * Ensure new updates always reload the page properly. ([#502](#502) by @7w1) * Removed the blocked users moved notice from notifications setting page. ([#490](#490) by @7w1) * Fix recieved encrypted message per-message profiles not triggering rerenders. ([#464](#464) by @7w1) * Add `.m4a` files as a recognized audio type. ([#472](#472) by @henk717) * Fix messages disappearing from rooms after reconnects and timeline resets. ([#478](#478) by @hazre) * Fix Camera being enabled by default even when the client has it off pre joining in browsers that permit the video (Electron/Tauri as examples). ([#485](#485) by @Rawrington) * Fix cinny-dark-theme link colors being too dark ([#469](#469) by @Elec3137) * Fix "Default" menu item height in room notification switcher. ([#466](#466) by @polyjitter) * fix the issue of empty displaynames of a persona, causing an empty fallback message, it will now ommit the fallback, if the name is empty or only consists of whitespace ([#495](#495) by @dozro) * Fixed an Android issue where recording a voice message with headphones could leave audio stuck in low-quality mode until the app was restarted. ([#476](#476) by @hazre) * Fixed voice message scrubbing/seeking on Firefox by switching the recorder from WebM (no seek index) to Ogg/Opus. ([#476](#476) by @hazre) * fixes touchpad zooming behaviour ([#481](#481) by @integralfunction) * Fixes width mismatch for the call chat view. ([#460](#460) by @polyjitter) * Fix messages sent from sable showing wrong on other client(s) ([#468](#468) by @nushea) ## Documentation * Updated PR template and CONTRIBUTING.md to add AI disclosure requirement. ([#456](#456) by @Rosy-iso)
Description
This PR adds formatting for the pin events so that you can see the events that have been added or removed at a glance (up to 4 as this is what i thought was a reasonable limit maybe)

It also adds the chosen colors of users to the events of them leaving, joining, changing their name, the room name et cetera

Fixes #
Type of change
Checklist: