Skip to content

Fix PMPs not rendering on incoming encrypted messages#464

Merged
7w1 merged 1 commit intodevfrom
fix/encrypted-pmps
Mar 22, 2026
Merged

Fix PMPs not rendering on incoming encrypted messages#464
7w1 merged 1 commit intodevfrom
fix/encrypted-pmps

Conversation

@7w1
Copy link
Copy Markdown
Member

@7w1 7w1 commented Mar 21, 2026

Description

Fixes #366, again

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

No AI was used in this pr.

@7w1 7w1 requested a review from hazre as a code owner March 21, 2026 17:44
@github-actions
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-464-sable.raspy-dream-bb1d.workers.dev 4b463e3 pr-464 Sat, 21 Mar 2026 17:46:23 GMT

@dozro
Copy link
Copy Markdown
Contributor

dozro commented Mar 21, 2026

Was it only on incoming (bc title)? For me it was also on messages I sent in an encrypted room

@7w1
Copy link
Copy Markdown
Member Author

7w1 commented Mar 21, 2026

Was it only on incoming (bc title)? For me it was also on messages I sent in an encrypted room

Messages sent was fixed in the update last night. Or should've been at least...

@7w1 7w1 merged commit 5f8a2c8 into dev Mar 22, 2026
9 checks passed
@7w1 7w1 deleted the fix/encrypted-pmps branch March 22, 2026 02:02
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* `Ctrl + K` search menu is now context aware and lists the current
space's rooms at the top.
([#499](#499) by @7w1)
* Add knocking support when attempting to join a room from the
directory, an address, a room mention, or space hierarchy, as well as
text command support for knocking. Also improves rendering for knock
notifications in rooms.
([#470](#470) by @polyjitter)
* Add Android/iOS PWA-specific icon variants.
([#473](#473) by @Septicity)
* Add support for youtube embeds.
([#497](#497) by
@thundertheidiot)
* Add sidebar three dot menu for quick access to related settings
([#474](#474) by @wolterkam)
* Replies that mention the OP are now indicated by the OP username being
prefixed with @ ([#465](#465)
by @mini-bomba)
* Made pin events show a tally of the messages that are pinned.
([#462](#462) by @nushea)

### Improve multiline composer and voice recording
([#476](#476) by @hazre)

- Add a multiline composer layout for longer drafts.
- Keep the voice recorder between composer actions in multiline mode.
- Show the recorder inside the composer on mobile while recording.
- Prevent the composer from expanding when recording starts.
- Make the recorder footer and waveform fit better across screen sizes.
- Let interrupted mobile recording gestures still stop correctly.
- Stabilize wrap detection around edge cases like narrow widths and
trailing spaces.

## Fixes

* Added error messages provided by homeserver to unknown login errors.
([#496](#496) by @7w1)
* Ensure new updates always reload the page properly.
([#502](#502) by @7w1)
* Removed the blocked users moved notice from notifications setting
page. ([#490](#490) by @7w1)
* Fix recieved encrypted message per-message profiles not triggering
rerenders. ([#464](#464) by
@7w1)
* Add `.m4a` files as a recognized audio type.
([#472](#472) by @henk717)
* Fix messages disappearing from rooms after reconnects and timeline
resets. ([#478](#478) by
@hazre)
* Fix Camera being enabled by default even when the client has it off
pre joining in browsers that permit the video (Electron/Tauri as
examples). ([#485](#485) by
@Rawrington)
* Fix cinny-dark-theme link colors being too dark
([#469](#469) by @Elec3137)
* Fix "Default" menu item height in room notification switcher.
([#466](#466) by @polyjitter)
* fix the issue of empty displaynames of a persona, causing an empty
fallback message, it will now ommit the fallback, if the name is empty
or only consists of whitespace
([#495](#495) by @dozro)
* Fixed an Android issue where recording a voice message with headphones
could leave audio stuck in low-quality mode until the app was restarted.
([#476](#476) by @hazre)
* Fixed voice message scrubbing/seeking on Firefox by switching the
recorder from WebM (no seek index) to Ogg/Opus.
([#476](#476) by @hazre)
* fixes touchpad zooming behaviour
([#481](#481) by
@integralfunction)
* Fixes width mismatch for the call chat view.
([#460](#460) by @polyjitter)
* Fix messages sent from sable showing wrong on other client(s)
([#468](#468) by @nushea)

## Documentation

* Updated PR template and CONTRIBUTING.md to add AI disclosure
requirement. ([#456](#456) by
@Rosy-iso)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PMP does not work in encrypted rooms

2 participants