-
Notifications
You must be signed in to change notification settings - Fork 172
Large Cleanup of the x509 crate #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7478fb to
408abf9
Compare
der/Cargo.toml
Outdated
| rust-version = "1.57" | ||
|
|
||
| [dependencies] | ||
| flagset = { version = "^0.4.3", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:
| flagset = { version = "^0.4.3", optional = true } | |
| flagset = { version = "0.4.3", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
|
I have moved the early part of this PR into #422 for independent review. |
484475e to
46d4a10
Compare
|
@tarcieri @carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run |
42f7617 to
ac8f79b
Compare
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
|
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure. |
Signed-off-by: Nathaniel McCallum <[email protected]>
9a210fb to
a50dc37
Compare
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| #![no_std] | |||
| #![cfg_attr(not(test), no_std)] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will go ahead and approve this. Can take a look at the tests separately.
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.