der: use type's tag by default on derive(Choice) #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Member
|
I think the Instead, I think it would make sense to avoid making any presumptions about the ASN.1 type, but try to treat it as if it impls |
npmccallum
changed the title
Contributor
Author
|
@tarcieri I believe the latest version of this fixes your concerns. |
tarcieri
reviewed
Feb 11, 2022
tarcieri
requested changes
Feb 11, 2022
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
@npmccallum looks better now!
One suggestion
By default, presume that a choice enum's type implements FixedTag. For many cases, this means that no `#[asn1(...)]` is required at all. In particular, this means that deriving `Choice` for `SEQUENCE` types without a context-specific tag is now possible. Signed-off-by: Nathaniel McCallum <[email protected]>
tarcieri
approved these changes
Feb 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, presume that a choice enum's type implements FixedTag. For
many cases, this means that no
#[asn1(...)]is required at all. Inparticular, this means that deriving
ChoiceforSEQUENCEtypeswithout a context-specific tag is now possible.
Signed-off-by: Nathaniel McCallum [email protected]