Skip to content

Conversation

@npmccallum
Copy link
Contributor

Don't merge this yet. It is a work in progress.

@npmccallum npmccallum marked this pull request as draft February 5, 2022 16:32
@npmccallum npmccallum force-pushed the ext branch 7 times, most recently from 007a77e to 2abbb50 Compare February 7, 2022 22:24
This crate will house the X.509 `Extension` and `Extensions` types, as
well as standardized X.509 extension definition types.

Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
We can use `Default::default()` instead. The default value of `bool` is
already false.

Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum npmccallum force-pushed the ext branch 2 times, most recently from f2f785b to 482321b Compare February 9, 2022 01:11
This trait links types to their OIDs.

Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
}

/// A trait expressing the association of a type with an OID.
pub trait Typed {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably use a more descriptive name, but I'm having trouble thinking of a good one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about OidValue?

Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Copy link
Contributor Author

This has been (almost) superseded by #414. Closing.

@npmccallum npmccallum closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants