-
Notifications
You must be signed in to change notification settings - Fork 172
[WIP] Add x509-ext crate #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
007a77e to
2abbb50
Compare
This crate will house the X.509 `Extension` and `Extensions` types, as well as standardized X.509 extension definition types. Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
We can use `Default::default()` instead. The default value of `bool` is already false. Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
f2f785b to
482321b
Compare
This trait links types to their OIDs. Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
| } | ||
|
|
||
| /// A trait expressing the association of a type with an OID. | ||
| pub trait Typed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably use a more descriptive name, but I'm having trouble thinking of a good one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about OidValue?
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
|
This has been (almost) superseded by #414. Closing. |
Don't merge this yet. It is a work in progress.