Fix cargo test without --all-features
#348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel McCallum <[email protected]>
5 tasks
Contributor
Author
|
@carl-wallace Would you care to review this PR? |
tarcieri
reviewed
Jan 28, 2022
Comment on lines
75
to
+76
| #[cfg(feature = "pem")] | ||
| #[cfg(feature = "fingerprint")] |
Member
There was a problem hiding this comment.
Normally we put these on a single line ala:
Suggested change
| #[cfg(feature = "pem")] | |
| #[cfg(feature = "fingerprint")] | |
| #[cfg(all(feature = "pem", feature = "fingerprint"))] |
Member
|
It'd be good to update the CI config to capture this failure too |
Contributor
Author
|
This PR was superseded by #364. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathaniel McCallum [email protected]