Skip to content

Conversation

@npmccallum
Copy link
Contributor

This dynamically ensures that the various combinations of features flags
successfully work.

Signed-off-by: Nathaniel McCallum [email protected]

@npmccallum
Copy link
Contributor Author

Please note that this PR is intended to reveal existing breakage.

@npmccallum npmccallum force-pushed the hack branch 5 times, most recently from a4250db to 29d1d5c Compare January 30, 2022 01:22
@franziskuskiefer
Copy link
Contributor

Thanks @npmccallum

The no_std support for tls_codec isn't really there yet (see #64). We can either disable default features on serde for no_std or not check for the serde_serialize feature on no_std platforms.

info: running `cargo build --release --target thumbv7em-none-eabi --no-default-features --features serde_serialize` on tls_codec (2/2)
   Compiling serde_derive v1.0.133
   Compiling serde v1.0.133
error[E0463]: can't find crate for `std`
  |
  = note: the `thumbv7em-none-eabi` target may not support the standard library
  = note: `std` is required by `serde` because it does not declare `#![no_std]`

This dynamically ensures that the various combinations of features flags
successfully work.

Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Copy link
Contributor Author

@franziskuskiefer I took a slightly different approach. Let me know if this doesn't work.

Copy link
Contributor

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franziskuskiefer I took a slightly different approach. Let me know if this doesn't work.

That works as well. Thanks!

@tarcieri tarcieri merged commit 51fca5a into RustCrypto:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants