Skip to content

Fix cargo test without --all-features #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
npmccallum wants to merge 1 commit into from
Closed

Fix cargo test without --all-features #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spki/tests/spki.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ fn decode_and_fingerprint_spki() {

#[test]
#[cfg(feature = "pem")]
#[cfg(feature = "fingerprint")]
Comment on lines 75 to +76
Copy link
Member

@tarcieri tarcieri Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we put these on a single line ala:

Suggested change
#[cfg(feature = "pem")]
#[cfg(feature = "fingerprint")]
#[cfg(all(feature = "pem", feature = "fingerprint"))]

fn decode_ed25519_pem() {
let doc: PublicKeyDocument = ED25519_PEM_EXAMPLE.parse().unwrap();
assert_eq!(doc.as_ref(), ED25519_DER_EXAMPLE);
Expand All @@ -84,6 +85,7 @@ fn decode_ed25519_pem() {

#[test]
#[cfg(feature = "alloc")]
#[cfg(feature = "fingerprint")]
fn encode_ed25519_der() {
let pk = SubjectPublicKeyInfo::try_from(ED25519_DER_EXAMPLE).unwrap();
let pk_encoded = pk.to_vec().unwrap();
Expand All @@ -92,6 +94,7 @@ fn encode_ed25519_der() {

#[test]
#[cfg(feature = "pem")]
#[cfg(feature = "fingerprint")]
fn encode_ed25519_pem() {
let pk = SubjectPublicKeyInfo::try_from(ED25519_DER_EXAMPLE).unwrap();
let pk_encoded = PublicKeyDocument::try_from(pk)
Expand Down