set opret/tapret host if needed#46
Conversation
dr-orlovsky
left a comment
There was a problem hiding this comment.
This will wipe the first OP_RETURN if it is present in the tx (doe to some reason) and will force the first tapret to host the commitment, even if it was not intendend. Why we do not leave marking the proper outputs to the wallet devs?
b654087 to
79cd55a
Compare
Doing so from a rust piece of software is not an issue, provided Taking that into consideration, I think the best approach is thus to:
If you agree I'll be glad to proceed this way. |
|
Yes, I agree that this is the best approach |
79cd55a to
0d395e1
Compare
PR updated dropping automatic setting of commitment host and only making the required modules public. |
This PR adds support for automatically setting opret/tapret host if needed.
The implementation is similar to my previous rgb-std PRs #14 and #15.
Note: I made the
opretandtapretmodules frompsbtpublic (and not justpub(crate)) as they're also useful outside of rgb-wallet (e.g. we need to useopretin rgb-lib).