Conversation
dr-orlovsky
left a comment
There was a problem hiding this comment.
Some style improvements - otherwise LGTM. Why draft?
5cbe900 to
733d074
Compare
great, updated
This PR was set as draft since it could not work until note: I now introduced a commit that updates |
|
added a commit to update an outdated github action (actually to re-trigger CI as it failed for an internal error on the previous run) it still failed, though, with more internal errors the PR IMO is ready, the only test that failed in the previous run (build/cli) succeeds locally ( |
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK with nits. If you want, I can merge it as is; but if you prefer to address nits, this is also an option
7aae7fe to
2237967
Compare
liked the suggestions, updated |
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK 2237967
Very cool, thank you!
This PR adds the
set-hostcommand to setopret/taprethost, if needed.This is intended to be called by a user that has prepared a PSBT with an output ready for the commitment but needing to set it as a host, via CLI.
This comes from (and depends on) rgb-wallet PR #46, which initially did the same in the
paycommand but now only makesopretandtapretmodules public.