Skip to content

add tapret DFS path or opret host in psbt bundle CLI command#14

Merged
dr-orlovsky merged 3 commits intoRGB-WG:v0.8from
nicbus:psbt_bundle_set_tapret_opret
Jan 17, 2023
Merged

add tapret DFS path or opret host in psbt bundle CLI command#14
dr-orlovsky merged 3 commits intoRGB-WG:v0.8from
nicbus:psbt_bundle_set_tapret_opret

Conversation

@nicbus
Copy link
Member

@nicbus nicbus commented Dec 14, 2022

completing an RGB transfer using the CLI currently requires the user to prepare the PSBT to hold the committment (before psbt bundle for opret or afterwards for tapret), and there is no CLI command to do so (one either needs to use descriptor-wallet for walleting or write one in rust)

this PR attepmts to drop such requirement by adding the close method as an optional parameter (tapret as default, like for the blind command) and, if needed, automatically set tapret DFS path or opret host

this change should allow users to create PSBTs with their wallet software of choice and still be able to use the CLI to transfer RGB assets

PS: opening this on branch v0.8 instead of master as the .set_opret_host method is not available there (yet)

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments: seems like the logic used is non-standard (i.e. it doesn't checks for the first output matching criteria)

@nicbus nicbus force-pushed the psbt_bundle_set_tapret_opret branch from a4c6274 to b17d1a9 Compare January 4, 2023 09:11
@nicbus
Copy link
Member Author

nicbus commented Jan 4, 2023

notes:

  • new version also updates commit_verify and rgb-core dependencies
  • once this PR is accepted, let's also port this to the master branch, once .set_opret_host will be available (I can open a new PR if you want me to)

@nicbus nicbus force-pushed the psbt_bundle_set_tapret_opret branch from b17d1a9 to 1082320 Compare January 4, 2023 09:37
@nicbus
Copy link
Member Author

nicbus commented Jan 9, 2023

@dr-orlovsky could you please let me know if the changes are ok for you?

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review - missed in GitHub notifications :(

@nicbus nicbus force-pushed the psbt_bundle_set_tapret_opret branch from 1082320 to 28b05fd Compare January 17, 2023 15:44
@nicbus
Copy link
Member Author

nicbus commented Jan 17, 2023

@dr-orlovsky requested changes applied (with a note), could you please have a look?

@nicbus nicbus force-pushed the psbt_bundle_set_tapret_opret branch from 28b05fd to 7e16ff7 Compare January 17, 2023 17:34
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7e16ff7

@dr-orlovsky dr-orlovsky merged commit 7999897 into RGB-WG:v0.8 Jan 17, 2023
@dr-orlovsky dr-orlovsky added this to the v0.9.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants