add tapret DFS path or opret host in psbt bundle CLI command#14
Merged
dr-orlovsky merged 3 commits intoRGB-WG:v0.8from Jan 17, 2023
Merged
add tapret DFS path or opret host in psbt bundle CLI command#14dr-orlovsky merged 3 commits intoRGB-WG:v0.8from
dr-orlovsky merged 3 commits intoRGB-WG:v0.8from
Conversation
dr-orlovsky
reviewed
Dec 15, 2022
Member
dr-orlovsky
left a comment
There was a problem hiding this comment.
Please see my comments: seems like the logic used is non-standard (i.e. it doesn't checks for the first output matching criteria)
a4c6274 to
b17d1a9
Compare
Member
Author
|
notes:
|
b17d1a9 to
1082320
Compare
Member
Author
|
@dr-orlovsky could you please let me know if the changes are ok for you? |
dr-orlovsky
requested changes
Jan 17, 2023
Member
dr-orlovsky
left a comment
There was a problem hiding this comment.
Sorry for the late review - missed in GitHub notifications :(
1082320 to
28b05fd
Compare
Member
Author
|
@dr-orlovsky requested changes applied (with a note), could you please have a look? |
dr-orlovsky
requested changes
Jan 17, 2023
28b05fd to
7e16ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completing an RGB transfer using the CLI currently requires the user to prepare the PSBT to hold the committment (before
psbt bundlefor opret or afterwards for tapret), and there is no CLI command to do so (one either needs to usedescriptor-walletfor walleting or write one in rust)this PR attepmts to drop such requirement by adding the close method as an optional parameter (tapret as default, like for the
blindcommand) and, if needed, automatically set tapret DFS path or opret hostthis change should allow users to create PSBTs with their wallet software of choice and still be able to use the CLI to transfer RGB assets
PS: opening this on branch v0.8 instead of master as the
.set_opret_hostmethod is not available there (yet)