Skip to content

Refactor ci flow#181

Merged
dr-orlovsky merged 11 commits intoRGB-WG:developfrom
yanganto:v0.11-msrv
May 23, 2024
Merged

Refactor ci flow#181
dr-orlovsky merged 11 commits intoRGB-WG:developfrom
yanganto:v0.11-msrv

Conversation

@yanganto
Copy link
Contributor

@yanganto yanganto commented Apr 8, 2024

Fix MSRV issue of #178

  • Bumps MSRV
  • CI will use MSRV from Rust manifest (Cargo.toml)
  • reduce using actions-rs, which is no longer maintained after Oct 13, 2023.
  • Reduce usage of actions-rs, which are no longer maintained after Oct 13, 2023.
  • Set up dependency upgrade bot
  • Refactor lint, test, build with Nix
  • Allow codecov upload failure

@yanganto yanganto mentioned this pull request Apr 8, 2024
@yanganto yanganto marked this pull request as ready for review April 8, 2024 07:25
@yanganto
Copy link
Contributor Author

yanganto commented Apr 8, 2024

@dr-orlovsky
Please be kindly reminded.
This PR will go into v0.11 not master, and solve the trivial CI issues.

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Apr 9, 2024
@yanganto yanganto marked this pull request as draft April 23, 2024 05:47
@yanganto yanganto changed the title ci: bump MRSV Refactor ci flow Apr 23, 2024
@yanganto yanganto changed the base branch from v0.11 to master April 23, 2024 06:59
@yanganto yanganto force-pushed the v0.11-msrv branch 2 times, most recently from cea5fab to fa2803d Compare April 23, 2024 08:48
@codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@8ee3144). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             develop   #181   +/-   ##
========================================
  Coverage           ?   9.1%           
========================================
  Files              ?     37           
  Lines              ?   6699           
  Branches           ?      0           
========================================
  Hits               ?    612           
  Misses             ?   6087           
  Partials           ?      0           
Flag Coverage Δ
rust 9.1% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanganto
Copy link
Contributor Author

The codecov sometimes works and sometimes does not, because there is a quota limitation on tokenless usage.

error - 2024-04-23 09:04:16,536 -- Upload failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 520 seconds."}

@yanganto yanganto marked this pull request as ready for review April 23, 2024 09:06
@yanganto yanganto force-pushed the v0.11-msrv branch 2 times, most recently from 462ae08 to 133c6bf Compare April 23, 2024 16:15
@yanganto yanganto changed the base branch from master to develop April 30, 2024 01:18
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 740bbd4

@dr-orlovsky dr-orlovsky merged commit 2ca488c into RGB-WG:develop May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants