Skip to content

Add contrainers round trip checks#199

Merged
dr-orlovsky merged 18 commits intoRGB-WG:developfrom
yanganto:containers-check
May 24, 2024
Merged

Add contrainers round trip checks#199
dr-orlovsky merged 18 commits intoRGB-WG:developfrom
yanganto:containers-check

Conversation

@yanganto
Copy link
Contributor

@yanganto yanganto commented Apr 30, 2024

  • Based on Refactor ci flow #181, such that all the CI can be used for this feature branch
  • Add round trips checks for Contract, Transfer, and Kit
  • Impl FromStr traits for Contract, Transfer, and Kit
  • Add checks for wrong armored strings

@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 97.57282% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@8ee3144). Click here to learn what that means.

Files Patch % Lines
src/containers/consignment.rs 94.3% 8 Missing ⚠️
src/containers/kit.rs 96.4% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             develop    #199   +/-   ##
=========================================
  Coverage           ?   16.0%           
=========================================
  Files              ?      37           
  Lines              ?    7105           
  Branches           ?       0           
=========================================
  Hits               ?    1140           
  Misses             ?    5965           
  Partials           ?       0           
Flag Coverage Δ
rust 16.0% <97.6%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanganto yanganto force-pushed the containers-check branch 2 times, most recently from 83e3bff to a1d7329 Compare May 1, 2024 04:38
@yanganto yanganto force-pushed the containers-check branch from a1d7329 to 1d5f39e Compare May 2, 2024 01:41
@yanganto yanganto marked this pull request as ready for review May 2, 2024 02:25
@yanganto yanganto marked this pull request as draft May 2, 2024 07:03
@yanganto yanganto force-pushed the containers-check branch from 2715539 to bf39a9b Compare May 2, 2024 07:17
@yanganto yanganto marked this pull request as ready for review May 2, 2024 07:24
@yanganto yanganto force-pushed the containers-check branch from 1d410f5 to 7412362 Compare May 3, 2024 14:24
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone May 24, 2024
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7412362

@dr-orlovsky dr-orlovsky merged commit c34ca05 into RGB-WG:develop May 24, 2024
@dr-orlovsky
Copy link
Member

shit, again wrong target branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants