Closed
Conversation
Contributor
Author
|
covered by #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rgb-core v0.11.0-beta.5requires rustc 1.70.0 or newer, so the msrv bump. The msrv mentioned in README is incorrect with the 1.66 version, but the ci is using 1.69.0 as msrv.To avoid this issue in the future, the msrv will be based on
rust-versionofCargo.tomlas the single source of truth, the readme will refer to the file, and the ci will read the file and check on the build of msrv.