-
Notifications
You must be signed in to change notification settings - Fork 291
Object pose estimation and also some pipeline enhancement #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 17 commits
c836ba1
b309348
f5c2b4e
e051e84
3d11b75
61ca96d
e26c4cc
2d3d923
c7531de
08412fd
e0d6a0d
82882f5
83be30f
5671000
0584d28
a06bde6
bb1ef6d
62c889e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,9 +30,9 @@ export enum TargetModel { | |
| InfiniteRechargeHighGoalOuter = 2, | ||
| CircularPowerCell7in = 3, | ||
| RapidReactCircularCargoBall = 4, | ||
| AprilTag6in_16h5 = 5, | ||
| AprilTag6p5in_36h11 = 6, | ||
| ReefscapeAlgae = 7 | ||
| ReefscapeAlgae = 5, | ||
| AprilTag6in_16h5 = 6, | ||
| AprilTag6p5in_36h11 = 7 | ||
| } | ||
|
|
||
| export interface PipelineSettings { | ||
|
|
@@ -313,8 +313,8 @@ export const DefaultObjectDetectionPipelineSettings: ObjectDetectionPipelineSett | |
| ...DefaultPipelineSettings, | ||
| pipelineType: PipelineType.ObjectDetection, | ||
| cameraGain: 20, | ||
| targetModel: TargetModel.InfiniteRechargeHighGoalOuter, | ||
| ledMode: true, | ||
| targetModel: TargetModel.ReefscapeAlgae, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this changed?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that.... that was me being an idiot and forgetting how things work. sorry. |
||
| ledMode: false, | ||
| outputMaximumTargets: 20, | ||
| cameraExposureRaw: 6, | ||
| confidence: 0.9, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ protected List<NeuralNetworkPipeResult> process(CVMat in) { | |
| return List.of(); | ||
| } | ||
|
|
||
| return detector.detect(in.getMat(), params.nms(), params.confidence()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why was this changed? there needs to be great caution with where mat's get returned, we've had memory leak issues from things like this in the past
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will revert. |
||
| return detector.detect(frame, params.nms(), params.confidence()); | ||
| } | ||
|
|
||
| public static record ObjectDetectionPipeParams(double confidence, double nms, Model model) {} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these reordered?