Object pose estimation and also some pipeline enhancement #2397
Object pose estimation and also some pipeline enhancement #2397Ruthie-FRC wants to merge 18 commits intoPhotonVision:mainfrom
Conversation
…tionPipelineSettings
…jectDetectionPipelineSettings
github-actions
bot
added
frontend
…timize result processing
…mprove detection error handling
…or spherical and non-symmetric targets
… to constructor for clarity
|
this is just a first attempt at it but figured I might as well get some feedback |
| InfiniteRechargeHighGoalOuter = 2, | ||
| CircularPowerCell7in = 3, | ||
| RapidReactCircularCargoBall = 4, | ||
| AprilTag6in_16h5 = 5, |
| cameraGain: 20, | ||
| targetModel: TargetModel.InfiniteRechargeHighGoalOuter, | ||
| ledMode: true, | ||
| targetModel: TargetModel.ReefscapeAlgae, |
There was a problem hiding this comment.
that.... that was me being an idiot and forgetting how things work. sorry.
gerth2
left a comment
gerth2
left a comment
There was a problem hiding this comment.
Any screenshots or videos of this working? No testcases were updated
| return List.of(); | ||
| } | ||
|
|
||
| return detector.detect(in.getMat(), params.nms(), params.confidence()); |
There was a problem hiding this comment.
why was this changed? there needs to be great caution with where mat's get returned, we've had memory leak issues from things like this in the past
|
as a general note, this is a sizeable feature add. It should probably wait for a post-champs merge. |
|
2 participants
Description
What changed? Why? (the code + comments should speak for itself on the "how")
Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future.
Any issues this pull request closes or pull requests this supersedes should be linked with
Closes #issuenumber.improved object detection pipeline configuration and processing. enhancements to 3D processing in the object detection pipeline, adjustments to default settings, and improvements to configuration options filtering.
closes #2284
Meta
Merge checklist: